-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/support for excluding with glob #1712
Feature/support for excluding with glob #1712
Conversation
Generated by 🚫 Danger |
Thanks for your work on this! A few thoughts:
|
Codecov Report
@@ Coverage Diff @@
## master #1712 +/- ##
==========================================
+ Coverage 87.61% 87.83% +0.22%
==========================================
Files 214 220 +6
Lines 10534 10848 +314
==========================================
+ Hits 9229 9528 +299
- Misses 1305 1320 +15
Continue to review full report at Codecov.
|
Hi.
|
@jpsim could you review my recent changes please? |
Is there anything I can do to help push this PR forward? I have no idea what Glob is, but I really think the ability to exclude files with a regex is invaluable. |
Are there any plans to continue or replace this PR? |
If this is to be considered, the next steps are to rebase the PR (no merge commits please) and have it pass all CI checks. |
|
I've implemented an alternative to this here: #2316 |
This has been merged in #2316 and is part of 0.27.0. I think we can close this PR |
Addressing issue #1220. Added support for excluding files using globs.
For example, if you want to exclude all test files in project you can add following line into your .swiftlint.yml: