Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update swiftlint/Commands to follow Swift 3 API Design Guidelines #1144

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Jan 10, 2017

Depends on #1143. 6 out of 7 Swift 3 API Guidelines PRs. /cc @marcelofabri

@SwiftLintBot
Copy link

SwiftLintBot commented Jan 10, 2017

1 Error
🚫 Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
5 Messages
📖 Linting Alamofire with this PR took 9.04s vs 8.48s on master (6% slower)
📖 Linting Aerial with this PR took 0.92s vs 0.88s on master (4% slower)
📖 Linting SourceKitten with this PR took 4.53s vs 4.74s on master (4% faster)
📖 Linting Moya with this PR took 0.95s vs 0.93s on master (2% slower)
📖 Linting realm-cocoa with this PR took 9.64s vs 9.29s on master (3% slower)

Here's an example of your CHANGELOG entry:

* update swiftlint/Commands to follow Swift 3 API Design Guidelines.  
  [jpsim](https://github.com/jpsim)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 danger

@jpsim jpsim force-pushed the jp-api-guidelines-cli-commands branch 5 times, most recently from 5584b11 to b479ca1 Compare January 10, 2017 04:44
@codecov-io
Copy link

codecov-io commented Jan 10, 2017

Current coverage is 82.71% (diff: 90.88%)

Merging #1144 into master will decrease coverage by 0.11%

@@             master      #1144   diff @@
==========================================
  Files           161        161          
  Lines          7971       7916    -55   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           6603       6548    -55   
  Misses         1368       1368          
  Partials          0          0          

Powered by Codecov. Last update 86ebc9c...b479ca1

@jpsim jpsim merged commit 706bf72 into master Jan 10, 2017
@jpsim jpsim deleted the jp-api-guidelines-cli-commands branch January 10, 2017 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants