Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #921.
As I wasn't able to reproduce the issue, I'm not sure this actually fixes the problem, but it was the only reason I found to makecontents.substringWithByteRange(start: lastPosition, length: length)
crash.I'll add a changelog once we confirm it does fix the issue.If it does, it'd good to have someone to add a break point in this guard to try to understand the issue and create a reproducible case so we can add tests and make sure we don't introduce a regression in the future.UPDATE: See #921 (comment)