Changing the default line length limit to 120 #1010
Conversation
| @@ -25,3 +25,4 @@ file_header: | |||
| \/\/ Created by .*? on \d{1,2}\/\d{1,2}\/\d{2}\. | |||
| \/\/ Copyright © \d{4} Realm\. All rights reserved\. | |||
| \/\/ | |||
| line_length: 120 | |||
There was a problem hiding this comment.
I've added this here to prevent the swiftlint build phase to generate warnings (since it's using the installed version, which probably is the latest stable one).
There was a problem hiding this comment.
Maybe we could log a message if a configuration has line length explicitly set to 120, so that more people will be aware that this is SwiftLint's new default?
There was a problem hiding this comment.
I don't feel it'd be very useful as some people may see to not relying on the defaults as a good practice?
There was a problem hiding this comment.
yeah, maybe. I'm a bit torn, so happy to go with your preference on this one.
Current coverage is 82.34% (diff: 80.95%)
|
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| ##### Breaking | |||
|
|
|||
| * None. | |||
| * `file_length` rule now has a default value of `120` for warnings. | |||
There was a problem hiding this comment.
Though not really a breaking change, I do approve of having it in this section to spread the word...
Fixes #1008.
I particularly don't like breaking lines on
(or->in function declarations, so I've changed the ones I've found now that we have a larger line length limit.