Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.0 doesn't recognize variable names properly #522

Closed
Tableau-David-Potter opened this issue Feb 10, 2016 · 5 comments · Fixed by #523
Closed

0.8.0 doesn't recognize variable names properly #522

Tableau-David-Potter opened this issue Feb 10, 2016 · 5 comments · Fixed by #523
Labels
bug Unexpected and reproducible misbehavior.

Comments

@Tableau-David-Potter
Copy link
Contributor

I just installed 0.8.0 and now SwiftLint is giving me an error on every variable name. For example:

    public func generateError(parameters parameters: [CVarArgType]) -> NSError {

        let error = self.generateError(format: self.localizedDescription, parameters: parameters)
        return error
    }

SwiftLint gives me the following error on the first line above at the first instance of parameters:

Variable Name Violation: Variable name should be between 3 and 45 characters long: 'parameters' (variable_name)

Background

  • Installed using brew install swiftlint
  • I'm using a config file that sets the max_length of variable_name to 45.
  • This didn't happen with 0.7.2.
@Tableau-David-Potter
Copy link
Contributor Author

Oh, one more thing. Apparently there is no way to revert to a specific version of swiftlint using brew. Not sure how swiftlint is different than many other tools.

@jpsim
Copy link
Collaborator

jpsim commented Feb 11, 2016

Oh, one more thing. Apparently there is no way to revert to a specific version of swiftlint using brew. Not sure how swiftlint is different than many other tools.

That's a Homebrew limitation.

I'm looking into your first issue now.

@jpsim jpsim added the bug Unexpected and reproducible misbehavior. label Feb 11, 2016
jpsim added a commit that referenced this issue Feb 11, 2016
@jpsim
Copy link
Collaborator

jpsim commented Feb 11, 2016

I just merged a fix to master. Thanks for reporting this!

@Tableau-David-Potter
Copy link
Contributor Author

Thanks. When do you think it will be available via homebrew?

@jpsim
Copy link
Collaborator

jpsim commented Feb 11, 2016

I don't know when we'll be cutting the next release.

berikv pushed a commit to berikv/SwiftLint that referenced this issue Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected and reproducible misbehavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants