Error parsing .swiftlint.yml with mixed spaces/tabs

[NachoSoto]

I inadvertently introduced mixed spaces/tabs, and suddenly SwiftLint started linting Carthage/Checkouts. I wasn't sure what happened, until I saw this in the output:

expected colon, near "included:\n- Chess\n- ChessAPI\n- ChessAPITests\n- Che..."

My file looked something like this:

Once I changed everything to spaces, it started reading the configuration correctly. It took me a big to figure out what was going on, since at first I thought it was due to upgrading SwiftLint to 0.5.4.

I can think of 2 solutions:

• Short term: fail to lint altogether, with a warning to fix .swiftlint.yml.
• Longer term: improve parsing of file with mixed indentations.

Let me know if I can help at all 🚶

Thanks!

[jpsim]

This is related to #120.

Short term: fail to lint altogether, with a warning to fix .swiftlint.yml.

We currently fail if the file is invalid only if the config file was explicitly given (using --config): https://github.com/realm/SwiftLint/blob/0.5.4/Source/SwiftLintFramework/Models/Configuration.swift#L125-L152

However, I think it'd be more appropriate to always fail if the file was found but could not be parsed.

Longer term: improve parsing of file with mixed indentations.

SwiftLint uses https://github.com/behrang/YamlSwift to parse YAML, so support for mixed indentations should probably be added there.

[NachoSoto]

@jpsim thanks! I opened behrang/YamlSwift#17 to track the "longer term" plan.

[jpsim]

Cool, since short term has been merged, and long term is being tracked in the appropriate repo, I'll close this. Thanks for reporting!

[NachoSoto]

Thanks for fixing! ⭐