Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mixed spaces/tabs indentation #17

Closed
NachoSoto opened this issue Jan 3, 2016 · 3 comments
Closed

Support mixed spaces/tabs indentation #17

NachoSoto opened this issue Jan 3, 2016 · 3 comments

Comments

@NachoSoto
Copy link

This was originally found in SwiftLint: realm/SwiftLint#308.
@NachoSoto NachoSoto mentioned this issue Jan 3, 2016
Closed
@behrang
Copy link
Owner

behrang commented Jan 4, 2016

This is a bad idea. Since tabs can have different sizes in different editors, it will be ambiguous that two nodes are siblings or are parent/child. In the image in the related issue, if you change the tab size, the 3rd item will be positioned differently.

YamlSwift supports mixed spaces/tabs as long as there is no ambiguity.

@behrang behrang closed this as completed Jan 4, 2016
@NachoSoto
Copy link
Author

Makes sense. It would be nice to at least have better error handling so that users can be aware of what the problem is, considering how easy it is to inadvertently make this mistake.

@behrang
Copy link
Owner

behrang commented Jan 5, 2016

I agree, but I'm afraid it would be a little hard with current implementation. I keep it in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behrang @NachoSoto