Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocorrect Cosmetic Rules #2353

Closed
fabb opened this issue Aug 10, 2018 · 4 comments
Closed

Autocorrect Cosmetic Rules #2353

fabb opened this issue Aug 10, 2018 · 4 comments
Labels
wontfix Issues that became stale and were auto-closed by a bot.

Comments

@fabb
Copy link
Contributor

fabb commented Aug 10, 2018

Autocorrect is awesome (even more so when using File Watchers in AppCode and autocorrect a file on every save). There are some cosmetic (whitespace etc.) rules that would be cool if they got autocorrected as well:

closure_parameter_position
control_statement
implicit_getter
let_var_whitespace
modifier_order
multiline_function_chains
multiline_parameters
operator_whitespace
@realm-probot realm-probot bot added the O:User label Aug 10, 2018
abdulowork added a commit to abdulowork/SwiftLint that referenced this issue Dec 20, 2018
@abdulowork
realm#2353 - Move violating modifiers search to a private function
6651740
abdulowork added a commit to abdulowork/SwiftLint that referenced this issue Dec 20, 2018
@abdulowork
realm#2353 - Add offset and length to the ModifierDescription
b048521
abdulowork added a commit to abdulowork/SwiftLint that referenced this issue Dec 20, 2018
@abdulowork
realm#2353 - Make modifier_oder rule correctable
967adb8
abdulowork added a commit to abdulowork/SwiftLint that referenced this issue Dec 20, 2018
@abdulowork
realm#2353 - Add modifier_oder rule correction tests
fd77e87
abdulowork added a commit to abdulowork/SwiftLint that referenced this issue Dec 20, 2018
@abdulowork
realm#2353 - Upadte the changelog
35491f2
@abdulowork abdulowork mentioned this issue Dec 20, 2018
Merged
abdulowork added a commit to abdulowork/SwiftLint that referenced this issue Dec 20, 2018
@abdulowork
realm#2353 - Add missing Foundation import
f3f8593
abdulowork added a commit to abdulowork/SwiftLint that referenced this issue Dec 20, 2018
@abdulowork
realm#2353 - Fix linux tests
39b1baf
jpsim pushed a commit to abdulowork/SwiftLint that referenced this issue Dec 24, 2018
@abdulowork @jpsim
realm#2353 - Move violating modifiers search to a private function
783a69e
jpsim pushed a commit to abdulowork/SwiftLint that referenced this issue Dec 24, 2018
@abdulowork @jpsim
realm#2353 - Add offset and length to the ModifierDescription
401f24a
jpsim pushed a commit to abdulowork/SwiftLint that referenced this issue Dec 24, 2018
@abdulowork @jpsim
realm#2353 - Make modifier_oder rule correctable
830d0ee
jpsim pushed a commit to abdulowork/SwiftLint that referenced this issue Dec 24, 2018
@abdulowork @jpsim
realm#2353 - Add modifier_oder rule correction tests
c8b465f
jpsim pushed a commit to abdulowork/SwiftLint that referenced this issue Dec 24, 2018
@abdulowork @jpsim
realm#2353 - Upadte the changelog
7e42d61
jpsim pushed a commit to abdulowork/SwiftLint that referenced this issue Dec 24, 2018
@abdulowork @jpsim
realm#2353 - Add missing Foundation import
161d552
jpsim pushed a commit to abdulowork/SwiftLint that referenced this issue Dec 24, 2018
@abdulowork @jpsim
realm#2353 - Fix linux tests
3a0ed6b
jpsim pushed a commit that referenced this issue Dec 24, 2018
@abdulowork @jpsim
Make modifier_order rule autocorrectable (#2521)
735567d 
* #2353 - Move violating modifiers search to a private function

* #2353 - Add offset and length to the ModifierDescription

* #2353 - Make modifier_oder rule correctable

* #2353 - Add modifier_oder rule correction tests

* #2353 - Upadte the changelog

* #2353 - Add missing Foundation import

* #2353 - Fix linux tests

* Small edits to ModifierOrderRule and changelog entry
@zkrige
Copy link

zkrige commented Feb 26, 2019

Is it possible to make operator_whitespace autocorrect?

@marcelofabri
Copy link
Collaborator

@zkrige feel free to send a PR!

@zkrige
Copy link

zkrige commented Feb 28, 2019

I would gladly but I have no idea what I'm doing in swiftlint

sjavora pushed a commit to sjavora/SwiftLint that referenced this issue Mar 9, 2019
@abdulowork @sjavora
Make modifier_order rule autocorrectable (realm#2521)
744a9a7 
* realm#2353 - Move violating modifiers search to a private function

* realm#2353 - Add offset and length to the ModifierDescription

* realm#2353 - Make modifier_oder rule correctable

* realm#2353 - Add modifier_oder rule correction tests

* realm#2353 - Upadte the changelog

* realm#2353 - Add missing Foundation import

* realm#2353 - Fix linux tests

* Small edits to ModifierOrderRule and changelog entry
@stale
Copy link

stale bot commented Nov 8, 2020

This issue has been automatically marked as stale because it has not had any recent activity. Please comment to prevent this issue from being closed. Thank you for your contributions!

@stale stale bot added the wontfix Issues that became stale and were auto-closed by a bot. label Nov 8, 2020
@stale stale bot closed this as completed Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix Issues that became stale and were auto-closed by a bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabb @marcelofabri @zkrige