Possible closure_end_indentation rule issue

[erichoracek]

New Issue Checklist

• Updated SwiftLint to the latest version
• I searched for existing GitHub issues

Rule issue

I'm wondering whether the following code should be triggering the closure_end_indentation rule to fail (it currently doesn't):

function(
  parameter: a,
  closure: { x in
    // code
},
  anotherClosure: {
    // code
})

To me, this reads as a violation of the rule: since the closure's opening brace is on a line with one level of indentation, it seems like the closing brace should have the same level of indentation. The rule reads as follows:

"Closure end should have the same indentation as the line that started it.

My assumption from reading the rule is that the following code would satisfy it:

function(
  parameter: a,
  closure: { x in
    // code
  },
  anotherClosure: {
    // code
  })

From this, it would appear that currently, the rule treats "the line that started it" as the start of the function declaration, rather than the line on which the opening brace is located.

What do you think? Thanks in advance! cc @marcelofabri

[jpsim]

I agree with this, I'd consider the existing behavior to be a bug and the correct way to address is to fix the existing behavior, no need to create a new rule or configuration point.

[erichoracek]

@jpsim great to hear! I put up #2132 to update this rule to lint against this case. Thanks in advance for taking a look!