-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiline_parameters false positive when closures have default values #1912
Labels
bug
Unexpected and reproducible misbehavior.
Comments
allen-zeng
changed the title
multiline_parameters false positive when default values is a closure and contains commas
multiline_parameters false positive when closures have default values
Oct 18, 2017
That's a nice catch, @allen-zeng. Thanks! For debugging purposes, here's the report from sourcekitten func function(param1: Int,
param2: @escaping (Int, Int, Int) -> Void = { _, _, _ in }) { }
|
@marcelofabri would checking if "key.typename" is present would enough for this one? |
ornithocoder
added a commit
to ornithocoder/personal-fork-swiftlint
that referenced
this issue
Oct 18, 2017
when parameter is a closure has default value. Fixes realm#1912.
That was quick! Thanks @ornithocoder ! |
You're welcome @allen-zeng :D |
ornithocoder
added a commit
to ornithocoder/personal-fork-swiftlint
that referenced
this issue
Oct 21, 2017
when parameter is a closure has default value. Fixes realm#1912.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
New Issue Checklist
Bug Report
When there is a default parameter for a closure, linting fails.
Complete output when running SwiftLint, including the stack trace and command used
Environment
swiftlint version
to be sure)? 0.23.1xcode-select -p
)? 9.0The text was updated successfully, but these errors were encountered: