feat: Impl basic module and keeper methods #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| import ( | ||
| "fmt" | ||
| "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
sontrinh16
reviewed
Aug 14, 2024
x/asset/keeper/keeper.go
Outdated
| bankKeeper: bankKeeper, | ||
| ak: ak, | ||
| PrivilegesMap: privilegesMap, | ||
| func (k Keeper) AddPrivilege(priv types.PrivilegeI) error { |
There was a problem hiding this comment.
why this here, since privilege is set only during keeper initialization, we should not exposed an API to allow to add more privilege
There was a problem hiding this comment.
I think this is a clean way to input the privileges instead of a map. Also, We want to explicitly add each privilege by a separate API call (like when we add middleware to ibc transfer for example) instead of grouping them together in a map.
add tests for msg server
…etwork into basic-methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.