bump sdk50 #144
Open
bump sdk50 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacsomot
reviewed
Oct 22, 2024
| @@ -189,7 +207,7 @@ replace ( | |||
| // use cosmos fork of keyring | |||
| github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0 | |||
| // stick with compatible version or x/exp in v0.47.x line | |||
| golang.org/x/exp => golang.org/x/exp v0.0.0-20230711153332-06a737ee72cb | |||
| // golang.org/x/exp => golang.org/x/exp v0.0.0-20230711153332-06a737ee72cb | |||
| // stick with compatible version of rapid in v0.47.x line | |||
| pgregory.net/rapid => pgregory.net/rapid v0.5.5 | |||
There was a problem hiding this comment.
Should replace goleveldb too:
// replace broken goleveldb
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| lockID := types.MultiStakingLockID(msg.DelegatorAddress, msg.ValidatorAddress) | ||
| lockID := types.MultiStakingLockID(multiStakerAddr.String(), msg.ValidatorAddress) |
There was a problem hiding this comment.
DelegatorAddr is deprecated in sdk50. Maybe we shouldn't care this ?
| "github.com/cosmos/cosmos-sdk/store/prefix" | ||
| "cosmossdk.io/math" | ||
| "cosmossdk.io/store/prefix" | ||
| sdk_type "cosmossdk.io/store/types" |
There was a problem hiding this comment.
storetypes here for better readability
| @@ -25,8 +28,11 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| _ module.AppModule = AppModule{} | |||
| _ module.AppModuleBasic = AppModuleBasic{} | |||
| _ module.HasABCIGenesis = AppModule{} | |||
There was a problem hiding this comment.
Missing:
_ module.AppModuleBasic = AppModuleBasic{}
_ module.AppModuleSimulation = AppModule{}
_ module.HasInvariants = AppModule{}
_ appmodule.HasBeginBlocker = AppModule{}
| @@ -51,10 +37,4 @@ func init() { | |||
| RegisterLegacyAminoCodec(amino) | |||
trinitys7
reviewed
Oct 23, 2024
|
|
||
| app.BasicModuleManager = module.NewBasicManagerFromManager( |
There was a problem hiding this comment.
BasicModuleManager and ModuleBasics should only have one. Since we already have ModuleBasics, there is no need to add BasicModuleManager
trinitys7
reviewed
Oct 23, 2024
| ) | ||
|
|
||
| type Keeper struct { | ||
| storeKey storetypes.StoreKey | ||
| cdc codec.BinaryCodec | ||
| accountKeeper types.AccountKeeper | ||
| accountKeeper authkeeper.AccountKeeper |
There was a problem hiding this comment.
Should keep abstract interface here
| authority string | ||
| } | ||
|
|
||
| func NewKeeper( | ||
| cdc codec.BinaryCodec, | ||
| accountKeeper types.AccountKeeper, | ||
| accountKeeper authkeeper.AccountKeeper, |
There was a problem hiding this comment.
Should keep abstract interface here
| @@ -53,13 +55,14 @@ func (k Keeper) EndBlocker(ctx sdk.Context, matureUnbondingDelegations []staking | |||
| } | |||
|
|
|||
| func (k Keeper) BurnUnbondedCoinAndUnlockedMultiStakingCoin( | |||
| ctx sdk.Context, | |||
| c context.Context, | |||
There was a problem hiding this comment.
Should be ctx and sdkCtx
| func (k msgServer) UpdateMultiStakingParams(goCtx context.Context, msg *types.MsgUpdateMultiStakingParams) (*types.MsgUpdateMultiStakingParamsResponse, error) { | ||
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
| func (k msgServer) UpdateMultiStakingParams(ctx context.Context, msg *types.MsgUpdateMultiStakingParams) (*types.MsgUpdateMultiStakingParamsResponse, error) { | ||
| sdkctx := sdk.UnwrapSDKContext(ctx) |
| func (k msgServer) UpdateParams(goCtx context.Context, msg *stakingtypes.MsgUpdateParams) (*stakingtypes.MsgUpdateParamsResponse, error) { | ||
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
| func (k msgServer) UpdateParams(ctx context.Context, msg *stakingtypes.MsgUpdateParams) (*stakingtypes.MsgUpdateParamsResponse, error) { | ||
| sdkctx := sdk.UnwrapSDKContext(ctx) |
|
|
||
| multiStakerAddr, valAcc, err := types.AccAddrAndValAddrFromStrings(msg.DelegatorAddress, msg.ValidatorAddress) | ||
| func (k msgServer) CreateValidator(c context.Context, msg *stakingtypes.MsgCreateValidator) (*stakingtypes.MsgCreateValidatorResponse, error) { | ||
| ctx := sdk.UnwrapSDKContext(c) |
| @@ -38,9 +39,10 @@ func (k Keeper) GetUnlockEntryAtCreationHeight(ctx sdk.Context, unlockID types.U | |||
| // SetMultiStakingUnlockEntry adds an entry to the unbonding delegation at | |||
| // the given addresses. It creates the unbonding delegation if it does not exist. | |||
| func (k Keeper) SetMultiStakingUnlockEntry( | |||
| ctx sdk.Context, unlockID types.UnlockID, | |||
| c context.Context, unlockID types.UnlockID, | |||
| @@ -73,9 +75,10 @@ func (k Keeper) DeleteUnlockEntryAtCreationHeight( | |||
| } | |||
|
|
|||
| func (k Keeper) DecreaseUnlockEntryAmount( | |||
| ctx sdk.Context, unlockID types.UnlockID, | |||
| c context.Context, unlockID types.UnlockID, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.