[Java] Permit decoders to be built that do not validate empty tags #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,6 +131,21 @@ public CodecConfiguration wrapEmptyBuffer(final boolean wrapEmptyBuffer) | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Suppresses checks for empty tags, eg |1234=| | |||
| * instead of rejecting when tag is empty, treat the tag as absent | |||
There was a problem hiding this comment.
Not really, because you're still parsing those fields, the hasFoo() methods will return true. I think that's dangerous, because you won't be able to tell a difference between, for example, |43=N| and |43=|.
There was a problem hiding this comment.
Oh, damn, good point. I'll revise to make sure we don't parse the tags either and properly treat them as absent.
There was a problem hiding this comment.
I've now updated the change to not parse the tags, and added tests to assert those fields are absent (rather than present but empty/default).
I've included both String and non-String field tests too (to show it gracefully handles both parsed and non-parsed fields).
…ags: treat them as not present instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen numerous cases where venues are sending us invalid FIX of the form 35=0|12345=|10-123
ie, where a tag is defined with no value / an empty string.
This does not conform to the FIX standard, so it's technically correct to reject the message as malformed, however: if a venue's sending us that and is refusing to fix it (or is incapable of doing so), we'd rather not fail validation and instead just treat it as empty.
This change allows a build-time flag on generated decoders to ignore empty tags instead of rejecting them.