Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeating group decoder freshly allocated on each message, violating garbage free assumptions #532

Closed
writeoncereadmany opened this issue Dec 6, 2024 · 2 comments

Comments

@writeoncereadmany
Copy link

In trying to upgrade to latest Artio, we've found that the decoders are no longer garbage free in the steady state (thanks to our allocation tests).

Specifically: when decoding messages with repeating groups, the repeating group decoder is now nulled out on reset, meaning instead of it being a lazily allocated reused field, it's now freshly allocated each decode.

This was implemented in #525: there are other potential approaches such as resetting the fields of the group decoder or giving it some sentinel value to show that it's now dirty.

lucianoviana added a commit to lucianoviana/artio that referenced this issue Dec 9, 2024
…n old group references were being nullified which caused unecessary allocation on new decodings
@JackBeezer
Copy link

Thanks for raising this, we will take a look and update you with any progress.

lucianoviana added a commit that referenced this issue Dec 10, 2024
…p references were being nullified which caused unecessary allocation on new decodings
@lucianoviana
Copy link
Contributor

bug fix is now merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants