Scope autodoc styling to .class and .data for Sphinx 2.0 #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to have a review here @davidfischer or @agjohnson 👍 |
davidfischer
approved these changes
Jun 28, 2019
There was a problem hiding this comment.
When reviewing without whitespace this is a pretty small change. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx 2.0+ uses less table elements and more definition lists for layout. This causes styling for
autodoc,classetc. to interfere with other layout.This PR scopes the styling to definition lists in
.classor.data, which is all we use in the demo docs. There may be more examples in the wild, but at least this fixes glossaries.The diff looks larger than it is, only changes to the SASS is an added comment and two classes. Rest of the changes is due to added indentation.
Fixes #752. Affects #741, but does not fix it