Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct handling of __init__.pyi #406

Closed
wants to merge 0 commits into from
Closed

fix: Correct handling of __init__.pyi #406

wants to merge 0 commits into from

Conversation

laggykiller
Copy link
Contributor

@laggykiller laggykiller commented Sep 22, 2023 •
edited
Loading

Solves #405

Might be a good idea to cleanup a bit though?

@laggykiller laggykiller mentioned this pull request Sep 22, 2023
Closed
@laggykiller laggykiller marked this pull request as draft September 22, 2023 19:47
@laggykiller laggykiller marked this pull request as ready for review September 22, 2023 19:58
AWhetter
AWhetter requested changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@AWhetter AWhetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change. It looks promising.

Please could you also add a test case for this scenario that fails without your changes.
You'll also need to add a release notes fragment with towncrier. The README explains how to do this.

autoapi/mappers/python/parser.py Outdated Show resolved Hide resolved
@laggykiller
Copy link
Contributor Author

Done, please check!

@laggykiller laggykiller changed the title Correct handling of __init__.pyi fix: Correct handling of __init__.pyi Sep 27, 2023
@laggykiller
Copy link
Contributor Author

@AWhetter Seems like checks have failed, what went wrong?

@qryxip qryxip mentioned this pull request Dec 5, 2023
Merged
@AWhetter AWhetter closed this Feb 19, 2024
@AWhetter
Copy link
Collaborator

This got merged as 823c146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AWhetter AWhetter AWhetter requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laggykiller @AWhetter