Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Bump sphinx-rtd-theme 1.2.0rc4 #9989

Closed
wants to merge 2 commits into from

Conversation

benjaoming
Copy link
Contributor

Checking out readthedocs/sphinx_rtd_theme#1430

Noticing that sphinxcontrib-jquery 2.0.0 loads jQuery from Google CDN... didn't recall it'd do that. 3.0.0 has it bundled in but with a bug, and I've asked for a new release.

@agjohnson we currently run Sphinx 4.5.0 with this comment in pip.in.. it'd be interesting to know if we can bump this to some 6.x version to track things a bit closer through our own documentation work.

# For intersphinx during builds
# We need these pinned to build the docs properly
Sphinx==4.5.0
docutils==0.17.1

@benjaoming benjaoming added the Improvement Minor improvement to code label Feb 6, 2023
@benjaoming benjaoming requested a review from a team as a code owner February 6, 2023 17:18
@humitos
Copy link
Member

humitos commented Feb 7, 2023

We removed a lot of requirements from docs. You should update with main and re-run the pip-tools commands.

@benjaoming
Copy link
Contributor Author

Yes, 3 hours ago :)

@benjaoming
Copy link
Contributor Author

Well, we got it tested for a PR build, but no reason to merge, can use 1.2.0 instead :)

@benjaoming benjaoming closed this Feb 8, 2023
@benjaoming benjaoming deleted the bump-sphinx-rtd-theme branch February 8, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants