Config: remove pipfile from schema #8851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
approved these changes
Jan 26, 2022
agjohnson
approved these changes
Jan 27, 2022
We don't support Pipfile and we decided we won't implement it for now (see #3181). I'm removing it from the schema and also its tests.
humitos
force-pushed
the
humitos/remove-pipfile-schema
branch
from
4bc117c
to
0902f6d
Compare
doismellburning
added a commit
to UKPythonAssociation/ukpa-internaldocs
that referenced
this pull request
Oct 1, 2023
I accidentally broke the RTD build with 253b4b6 when moving from requirements.txt to Pipenv This was not helped by not having automated tests for RTD builds - I have subsequently enabled RTD Pull Request Previews (https://docs.readthedocs.io/en/stable/pull-requests.html) to find out in advance if anything is broken(!) In terms of the core issue, RTD have decided to not support Pipenv (readthedocs/readthedocs.org#8851 etc.) so instead we shim things: Rather than adopt a full-on "make RTD use Pipenv for dependencies", this just has Pipenv generate a requirements.txt for RTD to use as it did previously
doismellburning
added a commit
to UKPythonAssociation/ukpa-internaldocs
that referenced
this pull request
Oct 1, 2023
I accidentally broke the RTD build with 253b4b6 when moving from requirements.txt to Pipenv This was not helped by not having automated tests for RTD builds - I have subsequently enabled RTD Pull Request Previews (https://docs.readthedocs.io/en/stable/pull-requests.html) to find out in advance if anything is broken(!) In terms of the core issue, RTD have decided to not support Pipenv (readthedocs/readthedocs.org#8851 etc.) so instead we shim things: Rather than adopt a full-on "make RTD use Pipenv for dependencies", this just has Pipenv generate a requirements.txt for RTD to use as it did previously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't support Pipfile and we decided we won't implement it for now (see
#3181). I'm removing it
from the schema and also its tests.