Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mkdocs default version #7546

Closed
wants to merge 1 commit into from
Closed

Update mkdocs default version #7546

wants to merge 1 commit into from

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Oct 7, 2020

Everything looking good in local testing.
The changelog doesn't mention anything breaking.

ref #7539

Everything looking good in local testing.
The changelog doesn't mention anything breaking.
@stsewd stsewd requested a review from a team October 7, 2020 16:10
Copy link

@Mailaender Mailaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems still broken:

before: https://docs.openra.net/en/latest/release/lua/
after: https://openhv.readthedocs.io/en/latest/release/lua/

Additionally the table of contents is partly gone.

@stsewd
Copy link
Member Author

stsewd commented Oct 7, 2020

@Mailaender if you are already using the latest version of mkdocs you should report those problems to mkdocs, this isn't related to rtd.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this affect to all the builds that are not pinning mkdocs? I think what we want here is a feature flag that uses mkdocs<1.2 only for new projects.

I don't think we have a plan to update build dependencies that we install by default, but if we don't, we should so we apply it every time we need it. Like this case.

@stsewd
Copy link
Member Author

stsewd commented Oct 8, 2020

Won't this affect to all the builds that are not pinning mkdocs? I think what we want here is a feature flag that uses mkdocs<1.2 only for new projects.

Yes, but this update isn't going to break the builds. Is just a minor update.

@ericholscher
Copy link
Member

This removes python 3 support, along with a number of other large changes: https://www.mkdocs.org/about/release-notes/#other-changes-and-additions-to-version-11 -- this will definitely break things for people.

@Mailaender
Copy link

They really shouldn't have snug that into a point release.

@stsewd
Copy link
Member Author

stsewd commented Oct 12, 2020

I think we can add this after #7524 is merged

@stsewd stsewd closed this Oct 12, 2020
@stsewd stsewd deleted the update-mkdocs branch October 12, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants