Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Pin setuptools only when required #10268

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Build: Pin setuptools only when required #10268

merged 1 commit into from
Apr 25, 2023

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Apr 25, 2023

Ref #8659 Closes #10263

@stsewd stsewd requested a review from a team as a code owner April 25, 2023 01:35
@stsewd stsewd requested a review from humitos April 25, 2023 01:35
humitos
humitos approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the code locally, but it looks good to me.

@stsewd stsewd merged commit 37a8227 into main Apr 25, 2023
@stsewd stsewd deleted the pin-setuptools-only-when-required branch April 25, 2023 22:36
stsewd added a commit that referenced this pull request Apr 26, 2023
@stsewd
Update docs about setuptools dependency
3011ac1 
Ref #10268
@stsewd stsewd mentioned this pull request Apr 26, 2023
Merged
stsewd added a commit that referenced this pull request Apr 26, 2023
@stsewd
Update docs about setuptools dependency (#10270)
37c8431 
Ref #10268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees

@stsewd stsewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated versions of sphinx and other dependencies being installed (with pyproject.toml), search stuck
2 participants
@stsewd @humitos