Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop creating a conf.py/mkdocs.yaml file automatically for users and doing magic #2483

Closed
agjohnson opened this issue Oct 31, 2016 · 8 comments · Fixed by #5609
Closed

Stop creating a conf.py/mkdocs.yaml file automatically for users and doing magic #2483

agjohnson opened this issue Oct 31, 2016 · 8 comments · Fixed by #5609
Assignees
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Oct 31, 2016

We should stop adding a conf.py file for projects that don't have one. We also used to do magic around README handling, we should remove it:

https://github.com/rtfd/readthedocs.org/blob/535f31540fea36a321d148cfee302b34e90adfc9/readthedocs/doc_builder/base.py#L97-L116

@stsewd
Copy link
Member

stsewd commented Nov 27, 2018

We could create a redirect for all projects? Also, for mkdocs projects, this is already done in the mkdocs side #1615 (comment)

For sphinx there isn't a configuration or an extension (I just did a simple google search). I guess we could write this in the rtd-extension, or just deal with this creating an index file. Why? Because people can even create docs without a README file, and hit the 404 issue.

@stsewd stsewd added the Needed: design decision A core team decision is required label Nov 27, 2018
@ericholscher ericholscher changed the title Autodetect build could handle README.* better Remove magic around README handling Apr 11, 2019
@ericholscher ericholscher added Accepted Accepted issue on our roadmap Good First Issue Good for new contributors and removed Needed: design decision A core team decision is required labels Apr 11, 2019
@ericholscher
Copy link
Member

Updated this issue to be about removing the magic around README handling.

@ericholscher ericholscher changed the title Remove magic around README handling Stop creating a conf.py file automatically for users and doing magic Apr 11, 2019
@saadmk11
Copy link
Member

If I understood correctly we need to remove this part of the code:
https://github.com/rtfd/readthedocs.org/blob/2872832d75ebd8098184e714b9101a455504e1eb/readthedocs/doc_builder/base.py#L106-L111

we will not support README to index creation anymore ?

and for sphinx builder we should remove this part of the code to not automatically create the config file:
https://github.com/rtfd/readthedocs.org/blob/2872832d75ebd8098184e714b9101a455504e1eb/readthedocs/doc_builder/backends/sphinx.py#L175-L177

which will generate a NOT_FOUND Error.
Can you Please confirm? if that's what needs to be done here?

@davidfischer
Copy link
Contributor

should remove this part of the code to not automatically create the config file

I will let others chime in as well, but I am in favor 👍 of removing this.

In general, I believe that Read the Docs should not make broken projects build that are unable to be built outside of Read the Docs. This will lead to more predictable builds.

@stsewd stsewd changed the title Stop creating a conf.py file automatically for users and doing magic Stop creating a conf.py/mkdocs.yaml file automatically for users and doing magic Dec 17, 2020
stsewd added a commit that referenced this issue Dec 17, 2020
This value has been the default since the start of the project
https://github.com/mkdocs/mkdocs/blob/0.13.0/mkdocs/config/defaults.py#L44

We should respect that default value,
(we should actually don't edit it at all #2483).

So, instead of trying to guess the docs dir always,
only try to guess it if the user doesn't have mkdocs.yaml file.

This should avoid any backwards compatibility and avoid weird bugs to
new users.

Closes #7539
stsewd added a commit that referenced this issue Jan 12, 2021
This value has been the default since the start of the project
https://github.com/mkdocs/mkdocs/blob/0.13.0/mkdocs/config/defaults.py#L44

We should respect that default value,
(we should actually don't edit it at all #2483).

So, instead of trying to guess the docs dir always,
only try to guess it if the user doesn't have mkdocs.yaml file.

This should avoid any backwards compatibility and avoid weird bugs to
new users.

Closes #7539
@astrojuanlu
Copy link
Contributor

It is my understanding that this is not a "Good First Issue"?

@stsewd stsewd removed the Good First Issue Good for new contributors label Sep 2, 2021
@stsewd
Copy link
Member

stsewd commented Sep 2, 2021

yeah, this is going to be handled when we have the new builders in place.

@humitos humitos self-assigned this Jul 4, 2023
@humitos
Copy link
Member

humitos commented Jul 10, 2023

There is a bunch of history here and lot of issues linked to this issue plus others that talk about probably the same thing. So, I'm doing a small summary of what we are doing here:

@humitos
Copy link
Member

humitos commented Jul 11, 2023

I sent the email to these users today 📧 🚀 . We set August 28th for the feature removal.

humitos added a commit to readthedocs/blog that referenced this issue Jul 12, 2023
)

* Post: doctools without configuration file deprecation announcement

Follows readthedocs/readthedocs.org#2483

* Adding the updated content from the HackMD.

* Fix RST

* Fix link

---------

Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
Archived in project
7 participants