Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github integration doesn't support a list for source_suffix #1871

Closed
mgeier opened this issue Dec 22, 2015 · 3 comments
Closed

Github integration doesn't support a list for source_suffix #1871

mgeier opened this issue Dec 22, 2015 · 3 comments

Comments

@mgeier
Copy link
Contributor

mgeier commented Dec 22, 2015

A custom source_suffix is supported (see #559), but if source_suffix is a list of suffixes, apparently only the first one is taken into account.
This leads to broken Github links to source files using any of the other suffixes.

@ericholscher
Copy link
Member

This is fixed, but depends on Sphinx's page_source_suffix. sphinx-doc/sphinx#2278 is trying to get that in a proper sphinx release. I thought it was already released.

@mgeier
Copy link
Contributor Author

mgeier commented Apr 9, 2016

This still doesn't work for me ...

Is this supposed to work now?

If yes, I'll have to investigate further ...

@agjohnson
Copy link
Contributor

No, this shouldn't be fixed yet. Looks like the 1.3.6 release has this fix, we need to bump up to this release. You can specify a specific Sphinx version with your requirements file however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants