Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EthicalAd: better ad position for Docsify #470

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Dec 12, 2024

Show how simple is to add a better ad positioning for a documentation tool that we know.

  1. Find the CSS selector that allows to detect the framework
  2. Find the CSS selector for the ad position
  3. Add small CSS for styling if required

Screenshot_2024-12-12_12-12-47

Related #447

Show how simple is to add a better ad positioning for a documentation tool that
we know.

1. Find the CSS selector that allows to detect the framework
2. Find the CSS selector for the ad position
3. Add small CSS for styling if required

Related #447
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice small change to add in.

@humitos humitos merged commit f885e96 into main Dec 16, 2024
4 checks passed
@humitos humitos deleted the humitos/better-ad-position-docsify branch December 16, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants