Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EthicalAds: Default to fixedfooter for smaller screens #447

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

EthicalAds: Default to fixedfooter for smaller screens #447

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a831f71
Default to fixedfooter for smaller screens
ericholscher Nov 22, 2024
3b7e92e
Small fixes
ericholscher Nov 22, 2024
a4ef3ab
Note it's a hack
ericholscher Nov 22, 2024
0f36172
Dont' edit addons.js
ericholscher Dec 11, 2024
3848033
Add classes and remove old fixedfooter logic
ericholscher Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/ethicalads.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,20 @@ export class EthicalAdsAddon extends AddonBase {
placement,
elementInsertBefore.lastChild,
);
} else if (window.innerWidth <= 1300 && window.innerWidth > 768) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed this logic and the same above. These conditionals are only evaluated once, so don't catch the window resizing or rotating. Users have to reload before the placement style would shift in this case. These widths might be better off as CSS media queries, which are reactive.

// Use fixed footer for smaller widths, but not mobile
placement.setAttribute("data-ea-type", "text");
placement.setAttribute("data-ea-style", "fixedfooter");
// TODO: THIS IS A HACK. IS THERE A BETTER WAY?
// Add margin to the bottom to avoid hiding bottom of content
const root_node = document.querySelector(docTool.getRootSelector());
root_node.style.marginBottom = "2em";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting a couple issues here, I haven't tried playing around with the styling here.

Altering style rules through Element.style ends up just adding a style="..." attribute to the element, which has a couple issues:

  • Inline style attributes can be blocked by CSP rules as unsafe.
  • Inline style attributes have the highest specificity in CSS, so the user loses control of this styling.

In both cases, it's better to use classes to apply rules to these elements.

// Copy append logic from above
const elementInsertBefore = document.body;
elementInsertBefore.insertBefore(
placement,
elementInsertBefore.lastChild,
);
}
}

Expand Down