Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout: do not add UTM parameters to downloads #347

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Flyout: do not add UTM parameters to downloads #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0904949
Flyout: do not add UTM parameters to downloads
humitos Jul 16, 2024
6e89d4c
Build with updated dependencies
humitos Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/readthedocs-addons.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/readthedocs-addons.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions src/flyout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,7 @@ export class FlyoutElement extends LitElement {
${Object.entries(this.config.versions.current.downloads).map(
([name, url]) =>
html`<dd>
<a href="${addUtmParameters(url, "flyout")}"
>${nameDisplay[name]}</a
>
<a href="${url}">${nameDisplay[name]}</a>
</dd>`,
)}
</dl>
Expand Down
4 changes: 2 additions & 2 deletions tests/__snapshots__/flyout.test.snap.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/flyout.test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
<dl class="downloads">
<dt>Downloads</dt>
<dd>
<a href="https://project.readthedocs.io/_/downloads/en/latest/pdf/?utm_source=project&amp;utm_content=flyout">PDF</a>
<a href="https://project.readthedocs.io/_/downloads/en/latest/pdf/">PDF</a>
</dd>
</dl>
`);
Expand Down