Skip to content

Commit

Permalink
Flyout: do not add UTM parameters to downloads (#347)
Browse files Browse the repository at this point in the history
These links point to the documentation domain and we don't receive stats
from those in our Plausible account, so it's useless to add UTM
parameters there. It seems I added them here by mistake.
  • Loading branch information
humitos authored Jul 17, 2024
1 parent 9e229e7 commit 8c9d66e
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 9 deletions.
4 changes: 2 additions & 2 deletions dist/readthedocs-addons.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/readthedocs-addons.js.map

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions src/flyout.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,7 @@ export class FlyoutElement extends LitElement {
${Object.entries(this.config.versions.current.downloads).map(
([name, url]) =>
html`<dd>
<a href="${addUtmParameters(url, "flyout")}"
>${nameDisplay[name]}</a
>
<a href="${url}">${nameDisplay[name]}</a>
</dd>`,
)}
</dl>
Expand Down
4 changes: 2 additions & 2 deletions tests/__snapshots__/flyout.test.snap.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/flyout.test.html
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
<dl class="downloads">
<dt>Downloads</dt>
<dd>
<a href="https://project.readthedocs.io/_/downloads/en/latest/pdf/?utm_source=project&amp;utm_content=flyout">PDF</a>
<a href="https://project.readthedocs.io/_/downloads/en/latest/pdf/">PDF</a>
</dd>
</dl>
`);
Expand Down

0 comments on commit 8c9d66e

Please sign in to comment.