Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for node 18, dropping node 12 #406

Merged
merged 6 commits into from
Apr 21, 2022
Merged

feat: adding support for node 18, dropping node 12 #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0c86245
feat: adding support for node 18, dropping node 12
erunion Apr 20, 2022
dfd8689
chore: bump the root lockfile
erunion Apr 20, 2022
c3c4f1c
ci: installing the latest npm 8 in most environmnets
erunion Apr 20, 2022
4c0446b
ci: install npm8 everywhere in ci
erunion Apr 20, 2022
d593b14
ci: debugging
erunion Apr 20, 2022
864e291
fix: add --ignore-scripts to `npm ci` in github action
domharrington Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,22 @@ jobs:
# node 16.14.2 ships with a buggy version of npm 🤷‍♂️
# https://github.com/nodejs/node/issues/42397
# TODO revert this back to 16.x when node pushes a new version
node-version: [12.x, 14.x, 16.14.0]
node-version:
- 14
- 16.14.0
- 18

steps:
- uses: actions/checkout@v3

- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

- name: Install npm@7
run: npm install -g npm@7

- name: Install deps
run: npm ci

- name: Run tests
run: npm test
# Node 14 still ships with npm@6 so for compatibility reasons we're upping
# this to match everything else.
- name: Install npm@8
if: matrix.node-version == '14'
run: npm install -g npm@8

env:
CI: true
- run: npm ci --ignore-scripts
- run: npm test
Loading