fix: emphasis with links #1007
Merged
fix: emphasis with links #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafegoldberg
approved these changes
Oct 30, 2024
| @@ -27,24 +27,40 @@ const trimEmphasis = (node: Emphasis | Strong, index: number, parent: Parent) => | |||
| let trimmed = false; | |||
|
|
|||
| visit(node, 'text', (child: Text) => { | |||
| const newValue = child.value.trim(); | |||
| const newValue = child.value.trimStart(); | |||
There was a problem hiding this comment.
Why do we have to trim the start and end separately? Oh I see now! In cases where there are multiple nodes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fixes emphasis with links in it.
The original implementation of this was naively assuming there would only be one child node. Ope.
🧬 QA & Testing