feat: allow download attr in a-tags (#39)

readmeio · Aug 4, 2020 · 87d8099 · 87d8099
1 parent bcfd936
commit 87d8099
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/__tests__/__snapshots__/index.test.js.snap b/__tests__/__snapshots__/index.test.js.snap
@@ -2,6 +2,8 @@
 
 exports[`anchor target: should allow _blank if using HTML 1`] = `"<p><a href=\\"https://example.com\\" target=\\"_blank\\" title=\\"\\">test</a></p>"`;
 
+exports[`anchor target: should allow download if using HTML 1`] = `"<p><a download=\\"example.png\\" href=\\"\\" target=\\"_blank\\" title=\\"\\">test</a></p>"`;
+
 exports[`anchor target: should default to _self 1`] = `"<p><a href=\\"https://example.com\\" target=\\"_self\\" title=\\"\\">test</a></p>"`;
 
 exports[`anchors 1`] = `

diff --git a/__tests__/index.test.js b/__tests__/index.test.js
@@ -105,6 +105,12 @@ test('anchor target: should allow _blank if using HTML', () => {
   expect(mount(markdown.default('<a href="https://example.com" target="_blank">test</a>')).html()).toMatchSnapshot();
 });
 
+test('anchor target: should allow download if using HTML', () => {
+  expect(
+    mount(markdown.default('<a download="example.png" href="" target="_blank">test</a>')).html()
+  ).toMatchSnapshot();
+});
+
 test('anchors with baseUrl', () => {
   const wrapper = mount(
     React.createElement(

diff --git a/components/Anchor.jsx b/components/Anchor.jsx
@@ -57,6 +57,7 @@ function Anchor(props) {
 Anchor.propTypes = {
   baseUrl: PropTypes.string,
   children: PropTypes.node.isRequired,
+  download: PropTypes.string,
   href: PropTypes.string,
   target: PropTypes.string,
   title: PropTypes.string,

diff --git a/index.js b/index.js
@@ -78,7 +78,7 @@ sanitize.attributes['rdme-embed'] = [
   'favicon',
 ];
 
-sanitize.attributes.a = ['href', 'title', 'class', 'className'];
+sanitize.attributes.a = ['href', 'title', 'class', 'className', 'download'];
 
 sanitize.tagNames.push('figure');
 sanitize.tagNames.push('figcaption');