Refactor R2RTLViewPager using ViewPager2 for better RTL and scroll behavior #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erkas-c
force-pushed
the
feature/convert_viewpager2
branch
from
ec77c9f to
9dd843c
Compare
|
I’ll be closing this PR because of issues with the commit history and will open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve migrated R2RTLViewPager to R2RTLViewPager2.
The key changes are as follows:
Applying RTL is now much simpler with ViewPager2.
With ViewPager2's support for both horizontal and vertical orientation,
WebViews can now be laid out vertically in scroll mode, which provides a better user experience.
In R2RTLViewPager2’s onInterceptTouchEvent(),
touch events are controlled based on the WebView's scroll state,
allowing for smoother swipe handling when switching between pages containing WebViews.