Skip to content

Conversation

mickael-menu
Copy link
Member

Fixed

OPDS

  • Fixed race conditions causing ConcurrentModificationException to be thrown when parsing an OPDS 2 feed.

  • Removed the global feed property in the OPDS2Parser, this was the culprit for the ConcurrentModificationException.
  • Made all the OPDS models immutable.
    • To avoid messing up with the existing parsing code, I added an internal mutable builder for all the models. When we're ready to revamp the OPDS models and APIs, we can remove them.

@mickael-menu mickael-menu requested a review from qnga October 5, 2023 12:37
@mickael-menu mickael-menu merged commit 8f66880 into v3 Oct 9, 2023
@mickael-menu mickael-menu deleted the fix/opds-models branch October 9, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants