Skip to content

Bugfixes for TTS #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2023
Merged

Bugfixes for TTS #391

merged 2 commits into from
Sep 15, 2023

Conversation

mickael-menu
Copy link
Member

  • Fix issue highlighting an utterance where the locator contained non-breaking spaces.
    • As we tokenized the sanitized utterance text, the tokenized locator didn't contain the original non breaking spaces. They seem to be relevant for Hypothesis.
    • Solved by keeping non breaking spaces in the sanitized utterance text.
  • Fix incorrect CSS selectors when text elements are located around a nested block element.

@mickael-menu mickael-menu requested a review from qnga September 15, 2023 15:20
@mickael-menu mickael-menu merged commit 4f4fec1 into v3 Sep 15, 2023
@mickael-menu mickael-menu deleted the fix/tts branch September 15, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qnga qnga qnga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickael-menu @qnga