Skip to content

Conversation

stevenzeck
Copy link
Contributor

@stevenzeck stevenzeck commented Jul 27, 2023

What was done

  1. androidx-compose-theme-adapter has been deprecated in favor of the one in Accompanist. Removed the former and added the latter.
  2. Updated a few lingering libraries.
  3. Replaced remaining uses of launchWhenStarted and launchWhenResumed with launch and repeatOnLifecycle.
  4. Used a Builder for DeviceInfo in TtsSessionAdapter, as the constructor was deprecated.
  5. Replaced onCreateOptionsMenu/onOptionsItemSelected with MenuHost/MenuProvider.
  6. Changed CatalogFragment/CatalogViewModel to use EventChannel instead of MutableLiveData.
  7. Added a background color back into search result headings.

@stevenzeck stevenzeck changed the base branch from main to v3 July 27, 2023 01:07
@stevenzeck stevenzeck marked this pull request as ready for review July 28, 2023 02:16
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for handling the grunt work @stevenzeck!

I adjusted the colors on the search fragment to work in dark mode and avoid hard-coded colors.
Screenshot_1690536656
Screenshot_1690536664

@mickael-menu mickael-menu merged commit 318971c into readium:v3 Jul 28, 2023
@mickael-menu mickael-menu deleted the cleanup branch July 28, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants