Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated yargs package to 13.1.0 version #59

Merged

Conversation

MaksPob
Copy link
Contributor

@MaksPob MaksPob commented Apr 5, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

There is a vulnerability in yargs package, because its version is old.
https://app.snyk.io/vuln/npm:mem:20180117

What is the new behavior?

I updated the version of the yargs package. Vulnerability should not be.

Does this PR introduce a breaking change?

  • Yes
  • No

I'm not sure.

Other information

You are using the old version of the yargs package, which at that time used the old version of the os-local package, which used the vulnerable version of the package mem.
https://app.snyk.io/vuln/npm:mem:20180117

Reviewers

@MartynasZilinskas @DovydasNavickas

@MartynasZilinskas
Copy link
Member

MartynasZilinskas commented Apr 5, 2019

Hey @MaksPob, thanks for the PR. Can you bump minor patch version as well?

@MaksPob MaksPob force-pushed the update-yargs-package-to-13-1 branch from a66bc54 to 22a4d6a Compare April 8, 2019 04:56
@MaksPob MaksPob force-pushed the update-yargs-package-to-13-1 branch from 63ebe71 to f95d421 Compare April 8, 2019 05:04
@MaksPob
Copy link
Contributor Author

MaksPob commented Apr 8, 2019

Hey @MaksPob, thanks for the PR. Can you bump minor patch version as well?

Hi @MartynasZilinskas! Ok i did it;))I understood you correctly?))

@MartynasZilinskas
Copy link
Member

@MaksPob Thanks. 👍

@MartynasZilinskas MartynasZilinskas merged commit c7166e4 into reactway:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants