fix: css imports with extension were not bundled in output. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/bundler.ts
Outdated
| @@ -8,7 +8,8 @@ import * as Helpers from "./helpers"; | |||
| const IMPORT_PATTERN = /@import\s+['"](.+)['"];/g; | |||
| const COMMENT_PATTERN = /\/\/.*$/gm; | |||
| const MULTILINE_COMMENT_PATTERN = /\/\*[\s\S]*?\*\//g; | |||
| const FILE_EXTENSION = ".scss"; | |||
| const DEFAULT_FILE_EXTENSION = ".scss"; | |||
| const ALLOWED_FILE_EXTENSIONS = [".scss", ".saas", ".css"]; | |||
There was a problem hiding this comment.
Does it really work with .sass?
There was a problem hiding this comment.
I tried https://www.sassmeister.com/ with this snippet and I failed:
.test {
color: red;
}
nav
ul
margin: 0
padding: 0
list-style: none
li
display: inline-block
a
display: block
padding: 6px 12px
text-decoration: none
MartynasZilinskas
requested changes
Aug 17, 2018
|
Good catch. I just renamed a scss file and tested 😞 Dropped the saas from allowed extension list now. |
|
It was a typo, it used to say |
MartynasZilinskas
approved these changes
Aug 17, 2018
|
@lazarljubenovic What do you mean? |
|
The code said |
|
@lazarljubenovic I just tested this will not work with @MartynasZilinskas Please move ahead with merge. |
|
🎉 |
|
v2.4.0 is released 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes #48 by looking for valid extensions before attaching default extension.
I used tar-ball of this PR and fixed #48 in a branch
git clone -b issue/48 https://github.com/arpit-agarwal/scss-bundle-issues.git
run npm install && npm start.
Theme file is generated as expected on destination location