Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning of missing rootDir parameter is logged, but rootDir is set in config #86

Closed
Akkora opened this issue Mar 19, 2020 · 0 comments · Fixed by #87
Closed

warning of missing rootDir parameter is logged, but rootDir is set in config #86

Akkora opened this issue Mar 19, 2020 · 0 comments · Fixed by #87

Comments

@Akkora
Copy link
Contributor

Akkora commented Mar 19, 2020

Describe the bug
A warn log message is sent if the property is set, but not if the property is missing. The handling is reverted.
warn: rootDir property is missing, using cwd.

To Reproduce
Steps to reproduce the behavior:

  1. Create a scss.bundle.config.json like:
{
  "bundlerOptions": {
    "rootDir": "my-project/src",
    [...]
  },
  [...]
}
  1. Start the SCSS bundler with --watch
scss-bundle -c my-project/src/scss-bundle.config.json --watch

Expected behavior
No warn log message is sent, if rootDir is set in config.

Package version: v0.0.0-canary.ad13f8e
Node version: v13.9.0
OS: Windows 10

MartynasZilinskas pushed a commit that referenced this issue Mar 19, 2020
* Fix configuration check and update log message. (#86)

* Updated version from 3.1.0 to 3.1.1.

Co-authored-by: Akkora <>
MartynasZilinskas pushed a commit that referenced this issue Mar 19, 2020
Hotfix: Fix configuration check and update log message. (#86) (#87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant