-
-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added quizeo play #162
added quizeo play #162
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel. @atapas first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For CSS Styles
Add prefix for all styles based on this comment:
"Add a play specific class name. Prefix that class name in all your style definitions. It will make sure there is no conflict with the file name.
We are planning to do this change at the framework level to take care of automatically. However, until that is in, please do this change."
And asked a few questions.
@vasantisuthar When you take care of the review comments and questions, please resolve merge conflicts too. After that can we do a quick call to finish the review? It is a bigger play, so just want to clarify some doubts before approving. It will be faster to merge. Need around 10-15 mins time. Let me know when based on your availability. |
@atapas tomorrow at 3:00 pm? |
…ed entry component and changed css
…t-play into vasantisuthar
src/plays/quizeo/src/components/menu-item/menuItem.component.js
Outdated
Show resolved
Hide resolved
src/plays/quizeo/src/components/menu-item/menuItem.component.js
Outdated
Show resolved
Hide resolved
…ed selectors for fetching the data from the state
@atapas kindly review the changes |
@vasantisuthar I picked it up for review. Please resolve the conflicts carefully. |
@vasantisuthar Are you still making changes? |
No, its done now.It is complete, it was just a small change to remove the logger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments..
a few more to come.
@vasantisuthar most of it looks good to me. I've noticed some impact on other plays due to conflicting styles. Could you please test it yourself using the preview URL? To be at the safer side, better to add a unique prefix to all your styles defined in your play's CSS files. |
Let's plan to merge the beast this week 😁 |
I have added the Quizeo-play
Fixes #115