Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when sending TCP/IP data to DNS server fails (macOS) #172

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

clue
Copy link
Member

@clue clue commented Feb 12, 2021

This changeset improves error handling when sending TCP/IP data to DNS server fails. This is a somewhat expected error condition as exhibited in our test suite. Additionally, there's a somewhat flaky error condition that can only be reproduced in some cases due to a kernel race condition on macOS.

Here's a quick link dump that describes this potential race condition in greater detail in other projects:

The gist is that with these changes applied, our test suite now works reliably also on macOS. Additionally, we include more error details to show the particular errno/errstr that caused the error, so this is something that benefits all platforms.

Together with #171, you're looking at ~16h of work. Hunting kernel race conditions is fun.

Builds on top of #171

@clue clue added this to the v1.5.0 milestone Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants