Improve error handling when sending TCP/IP data to DNS server fails (macOS) #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset improves error handling when sending TCP/IP data to DNS server fails. This is a somewhat expected error condition as exhibited in our test suite. Additionally, there's a somewhat flaky error condition that can only be reproduced in some cases due to a kernel race condition on macOS.
Here's a quick link dump that describes this potential race condition in greater detail in other projects:
The gist is that with these changes applied, our test suite now works reliably also on macOS. Additionally, we include more error details to show the particular errno/errstr that caused the error, so this is something that benefits all platforms.
Together with #171, you're looking at ~16h of work. Hunting kernel race conditions is fun.
Builds on top of #171