Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fileoptimizer.ico #260

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

marjuanm
Copy link
Contributor

Reupload file icon, the last is corrupted?

Reupload file icon, the last is corrupted?
@marjuanm
Copy link
Contributor Author

Please reupload this icon file, Rapps show this message in log file to try show fileoptimizer app:

fixme:(dll/win32/usp10/opentype.c:1262) TODO: subtype 1 (Simple context glyph substitution)
err:(win32ss/user/user32/windows/cursoricon.c:539) Corrupted icon file?.
err:(win32ss/user/user32/windows/cursoricon.c:539) Corrupted icon file?.
err:(win32ss/user/user32/windows/cursoricon.c:224) Cannot yet display PNG icons
err:(win32ss/user/user32/windows/cursoricon.c:1426) Failing File is
'C:\Documents and Settings\Administrator\Local Settings\Application Data\RApps\appdb\icons\fileoptimizer.ico'.
err:(win32ss/user/user32/windows/cursoricon.c:224) Cannot yet display PNG icons
err:(win32ss/user/user32/windows/cursoricon.c:1426) Failing File is
'C:\Documents and Settings\Administrator\Local Settings\Application Data\RApps\appdb\icons\fileoptimizer.ico'.

I send the file icon again, greetings to everyone.

@katahiromz
Copy link
Contributor

Cannot yet display PNG icons

@marjuanm
Copy link
Contributor Author

Yes @katahiromz, sorry, I send the file in correct format again.

Copy link
Contributor

@JoachimHenze JoachimHenze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only touch it, if you can provide a compatible icon for now. Your current proposal is not.

@marjuanm
Copy link
Contributor Author

@JoachimHenze How? I have uploaded the fileoptimizer.ico file to the icons folder again. I have already verified that it is indeed an ico file and not a png file (which was the previous case when the fileoptimizer app was registered in rapps).

@learn-more
Copy link
Member

This still looks like a png file renamed to .ico

@marjuanm
Copy link
Contributor Author

Yes, well, it was really a 32x32 png converted to ico with https://convertico.com/, but I tried with https://filehelper.com/ and in the file details it tells me:

File Properties
Name:
fileoptimizer.ico
MIME type:
image/x-icon
Size:
2KB
Modified:
Aug 11, 2024, 8:50 p.m.
Image Width:
32px
ImageHeight:
32px

With any other png image the result would be:

Name:
alf.png
MIME type:
image/png

I also tried with https://jumpshare.com/viewer/ico and if the image uploaded in ico it displays it, otherwise if it is a png we will get the error:

Whoops! Not the Right Type of File
This viewer only supports ICO files. The PNG file format you tried to upload is supported by a different viewer.

So, according to me, the icon has been created correctly and is the one I attached in this request. Should I generate the ico file in another way that passes the test?

Greetings, thank you.

@learn-more
Copy link
Member

Yes, well, it was really a 32x32 png converted to ico with https://convertico.com/, but I tried with https://filehelper.com/ and in the file details it tells me:

File Properties Name: fileoptimizer.ico MIME type: image/x-icon Size: 2KB Modified: Aug 11, 2024, 8:50 p.m. Image Width: 32px ImageHeight: 32px

With any other png image the result would be:

Name: alf.png MIME type: image/png

I also tried with https://jumpshare.com/viewer/ico and if the image uploaded in ico it displays it, otherwise if it is a png we will get the error:

Whoops! Not the Right Type of File This viewer only supports ICO files. The PNG file format you tried to upload is supported by a different viewer.

So, according to me, the icon has been created correctly and is the one I attached in this request. Should I generate the ico file in another way that passes the test?

Greetings, thank you.

$ file fileoptimizer\(1\).ico
fileoptimizer(1).ico: MS Windows icon resource - 1 icon, 32x32 with PNG image data, 32 x 32, 8-bit/color RGBA, non-interlaced, 32 bits/pixel

This is a png-encoded icon, which is invalid in this case.

@marjuanm
Copy link
Contributor Author

marjuanm commented Aug 13, 2024

Ok @learn-more, I have extracted the installer icon using "IconsExtract" from NirSoft, but the only icon it extracts measures 128x128 pixels. It seems to me that 32x32 are needed here, right?

@learn-more
Copy link
Member

Ok @learn-more, I have extracted the installer icon using "IconsExtract" from NirSoft, but the only icon it extracts measures 128x128 pixels. It seems to me that 32x32 are needed here, right?

That is a tad big indeed, but there are more icons like that, so as long as ReactOS can display it that would be fine with me.

Reupload FileOptimizer icon, at 128x128px, but this time it is a valid .ico.
@marjuanm
Copy link
Contributor Author

Ready, I have re-uploaded the ico file in 128x128, it was extracted directly from the FileOptimizer installer exe.

@learn-more learn-more merged commit 534ea42 into reactos:master Aug 14, 2024
1 check passed
@learn-more
Copy link
Member

Thanks for your contribution!

@marjuanm
Copy link
Contributor Author

Thanks!!!!

@marjuanm marjuanm deleted the Reupload-fileoptimizer-icon branch August 14, 2024 18:10
@marjuanm marjuanm restored the Reupload-fileoptimizer-icon branch August 14, 2024 18:19
@marjuanm marjuanm deleted the Reupload-fileoptimizer-icon branch August 14, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants