Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 7zip to 24.07 #258

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Update 7zip to 24.07 #258

merged 3 commits into from
Aug 14, 2024

Conversation

Darin755
Copy link
Contributor

@Darin755 Darin755 commented Aug 8, 2024

No description provided.

Copy link
Collaborator

@julenuri julenuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.exe(s) in x64 are not allowed.

7zip.txt Outdated Show resolved Hide resolved
Copy link
Member

@learn-more learn-more left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indicated issue.

Copy link
Collaborator

@julenuri julenuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Darin755, you can commit my suggestion here. 😄

7zip.txt Outdated Show resolved Hide resolved
Co-authored-by: Julen Urizar Compains <julenuri@hotmail.com>
7zip.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@JoachimHenze JoachimHenze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved now, after the 2 addendums. Rerequesting review from @learn-more

@Darin755
Copy link
Contributor Author

Is there anything else that needs to be done? Thanks @JoachimHenze

@learn-more learn-more merged commit 7284b5e into reactos:master Aug 14, 2024
1 check passed
@learn-more
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants