Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAPPS-DB] Add LMMS, Ren'Py, WinRAR, Sublime Text 3 #209

Merged
merged 10 commits into from
Dec 3, 2023

Conversation

QuetzalcoutlDev
Copy link
Contributor

A while ago I did some tests with ReactOS, and now I found out about the RAPPS repo so I can contribute with more applications

@JoachimHenze
Copy link
Contributor

Dear first time contributor, please add your full name to your github profile.

lmms.txt Outdated Show resolved Hide resolved
winrar.txt Outdated Show resolved Hide resolved
@QuetzalcoutlDev
Copy link
Contributor Author

@JoachimHenze I'm sorry, since this is my first contribution, I didn't know that it was necessary to put the SHA1 and the correct size in bytes (I used a converter from mb to bytes instead of seeing that just by clicking on the file properties it showed it to me)

@learn-more
Copy link
Member

Dear first time contributor, please add your full name to your github profile.

Not required for this repo.

@learn-more
Copy link
Member

You seem to have mixed line endings.

@QuetzalcoutlDev
Copy link
Contributor Author

You seem to have mixed line endings.

@learn-more I really don't know what that would be, I'm not a good programmer.

@JoachimHenze
Copy link
Contributor

JoachimHenze commented Oct 31, 2023

Line-endings are either CRLF CarriageReturnLineFeed on Windows, or just LF LineFeed on Linux.
The Windows-application Notepad++ has a feature for conversion between both (here is a screenshot, sorry german just)
image

Unfortunately we cannot merge your PR until our rapps-db-validation-script is happy with your files:
image
Not sure, why it points in the middle of the lines here even. Maybe it is worth to exclude the renpy.txt and sublime.txt as a first test and see whether we can merge just the others. That means if you cannot find the root-cause of the complaints.

@learn-more
Copy link
Member

Line-endings are either CRLF CarriageReturnLineFeed on Windows, or just LF LineFeed on Linux. The Windows-application Notepad++ has a feature for conversion between both (here is a screenshot, sorry german just) image

Unfortunately we cannot merge your PR until our rapps-db-validation-script is happy with your files: image Not sure, why it points in the middle of the lines here even. Maybe it is worth to exclude the renpy.txt and sublime.txt as a first test and see whether we can merge just the others. That means if you cannot find the root-cause of the complaints.

It points to the middle of the line because of the \xc3. This is something that I wanted to fix, but have not gotten around to.

@QuetzalcoutlDev
Copy link
Contributor Author

@learn-more Should the file format be in CRLF?

@learn-more
Copy link
Member

@learn-more Should the file format be in CRLF?

yes.

@JoachimHenze
Copy link
Contributor

@learn-more so can we ignore the validation script failure here? (I understood you that we do have a bug in the script and this PR is fine as is now)

sublime_text.txt Outdated Show resolved Hide resolved
@learn-more
Copy link
Member

@learn-more so can we ignore the validation script failure here? (I understood you that we do have a bug in the script and this PR is fine as is now)

Then you understood wrong.

Quetzalcoutl and others added 3 commits November 5, 2023 14:18
@QuetzalcoutlDev
Copy link
Contributor Author

@JoachimHenze After a fix that a colleague made to my PR, as far as I know, the bot approved the changes

@JoachimHenze JoachimHenze merged commit 29e6070 into reactos:master Dec 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants