Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wxMEdit #197

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Add wxMEdit #197

merged 6 commits into from
Aug 8, 2023

Conversation

hltj
Copy link
Contributor

@hltj hltj commented Aug 7, 2023

wxMEdit is a cross-platform Text/Hex Editor written in C++ & wxWidgets.
https://wxmedit.github.io/
One of its highlight features is that it still supports various encodings even in Hex mode, while many other editors can only support the current locale's encoding and Unicode encodings in Hex mode.

I'm the maintainer of wxMEdit and I've packaged it specifically for ReactOS. I will submit update PRs when new versions released in the future.

wxMEdit runs in ReactOS with Modern theme

@HBelusca
Copy link
Contributor

HBelusca commented Aug 7, 2023

Hi, and thanks for your interest!

I'm the maintainer of wxMEdit and I've packaged it specifically for ReactOS.

Why does it need to be specifically packaged for ROS? Is it a packaging different from what it would be for e.g. Windows XP or Windows 2003 ?

wxmedit.txt Outdated Show resolved Hide resolved
@hltj
Copy link
Contributor Author

hltj commented Aug 7, 2023

Hi, and thanks for your interest!

I'm the maintainer of wxMEdit and I've packaged it specifically for ReactOS.

Why does it need to be specifically packaged for ROS? Is it a packaging different from what it would be for e.g. Windows XP or Windows 2003 ?

I built wxmedit.exe and the dependent libraries with VC-LTL and YY-Thunks. Thus, programs originally only available for Windows 7 and later (e.g. ICU 73.2) can run on Windows XP to Vista. Unfortunately, the wxmedit.exe that built in this way currently can not run on ReactOS.

hltj and others added 2 commits August 7, 2023 22:13
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
@HBelusca
Copy link
Contributor

HBelusca commented Aug 7, 2023

Thus, programs originally only available for Windows 7 and later versions can run on Windows XP to Vista. Unfortunately, programs built in this way do not currently run on ReactOS.

Hmm... Interesting. Since we don't want programs to specifically target ReactOS, since ROS has to support whatever works on Windows XP / 2003 mainly, the fact that your builds that can run on WinXP don't run on ReactOS is certainly a bug of ours.

@hltj
Copy link
Contributor Author

hltj commented Aug 7, 2023

Thus, programs originally only available for Windows 7 and later versions can run on Windows XP to Vista. Unfortunately, programs built in this way do not currently run on ReactOS.

Hmm... Interesting. Since we don't want programs to specifically target ReactOS, since ROS has to support whatever works on Windows XP / 2003 mainly, the fact that your builds that can run on WinXP don't run on ReactOS is certainly a bug of ours.

It would be great if the program built in this way can run on ReactOS, then I don't have to package it specifically for ReactOS in the future.

This is the x86 package for Windows XP or later:
http://downloads.sourceforge.net/project/wxmedit/3.2/wxMEdit-3.2-win32-bin.zip

@JoachimHenze
Copy link
Contributor

JoachimHenze commented Aug 7, 2023

It would be great if the program built in this way can run on ReactOS, then I don't have to package it specifically for ReactOS in the future.

This is the x86 package for Windows XP or later: http://downloads.sourceforge.net/project/wxmedit/3.2/wxMEdit-3.2-win32-bin.zip

Yes, it sounds very rewarding for our project to support builds created with VC-LTL and YY-Thunks .
Please open a ticket in our JIRA bugtracker where you request us to fix that: https://jira.reactos.org

wxmedit.txt Outdated Show resolved Hide resolved
@JoachimHenze JoachimHenze self-requested a review August 7, 2023 21:49
wxmedit.txt Outdated Show resolved Hide resolved
wxmedit.txt Outdated Show resolved Hide resolved
wxmedit.txt Outdated Show resolved Hide resolved
Co-authored-by: Joachim Henze <joachim.henze@reactos.org>
wxmedit.txt Outdated Show resolved Hide resolved
@hltj
Copy link
Contributor Author

hltj commented Aug 8, 2023

It would be great if the program built in this way can run on ReactOS, then I don't have to package it specifically for ReactOS in the future.
This is the x86 package for Windows XP or later: http://downloads.sourceforge.net/project/wxmedit/3.2/wxMEdit-3.2-win32-bin.zip

Yes, it sounds very rewarding for our project to support builds created with VC-LTL and YY-Thunks . Please open a ticket in our JIRA bugtracker where you request us to fix that: https://jira.reactos.org

OK, I'll create JIRA ticket later. (done)

wxmedit.txt Outdated Show resolved Hide resolved
@binarymaster binarymaster merged commit 30db407 into reactos:master Aug 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants