Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure HttpClient#reactorNettyVersion() does not throw NullPointException when loaded through -javaagent under JDK 1.8 #3266

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

KyoUK4n
Copy link
Contributor

@KyoUK4n KyoUK4n commented May 27, 2024

Fixes #3265

@pivotal-cla
Copy link

@KyoUK4n Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@KyoUK4n Thank you for signing the Contributor License Agreement!

Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KyoUK4n Thanks for the PR!

@violetagg violetagg added the type/bug A general bug label May 27, 2024
@violetagg violetagg added this to the 1.0.46 milestone May 27, 2024
@violetagg violetagg changed the title fix: HttpClient.reactorNettyVersion() throws NullPointException Ensure HttpClient#reactorNettyVersion() does not throw NullPointException May 27, 2024
@violetagg violetagg changed the title Ensure HttpClient#reactorNettyVersion() does not throw NullPointException Ensure HttpClient#reactorNettyVersion() does not throw NullPointException when loaded through -javaagent under JDK 1.8 May 27, 2024
@violetagg violetagg merged commit b5199d0 into reactor:main May 27, 2024
14 checks passed
violetagg pushed a commit that referenced this pull request May 27, 2024
…tion when loaded through java agent under JDK 1.8 (#3266)
violetagg added a commit that referenced this pull request May 27, 2024
@KyoUK4n KyoUK4n deleted the getversion-npe-under-javaagent-loaded branch May 27, 2024 10:02
violetagg added a commit that referenced this pull request May 27, 2024
violetagg added a commit that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClient.reactorNettyVersion() throws NullPointException when loaded through -javaagent, under jdk 1.8
3 participants