Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translate useReducer #893

Merged
merged 13 commits into from
Apr 29, 2024
Merged

Add translate useReducer #893

merged 13 commits into from
Apr 29, 2024

Conversation

kmpeeduwee
Copy link
Contributor

No description provided.

@kmpeeduwee kmpeeduwee mentioned this pull request Jun 3, 2023
Open
titovmx
titovmx reviewed Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@titovmx titovmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет! Хороший перевод!
Заметил некоторое количество опечаток и проблем с пунктуацией - я бы рекомендовал прогнать всё через какой-нибудь редактор с проверкой орфографии.
Также по соглашению мы используем букву ё в переводах - используйте пакет eyo, чтобы найти все места где должна быть использована ё

src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
@kmpeeduwee @titovmx
Update src/content/reference/react/useReducer.md
e29b599 
Co-authored-by: Maxim <mtitov92@gmail.com>
@kmpeeduwee @titovmx
Update src/content/reference/react/useReducer.md
923ef96 
Co-authored-by: Maxim <mtitov92@gmail.com>
kmpeeduwee and others added 2 commits June 6, 2023 23:59
@kmpeeduwee @titovmx
Update src/content/reference/react/useReducer.md
8fd8343 
Co-authored-by: Maxim <mtitov92@gmail.com>
@kmpeeduwee @titovmx
Update src/content/reference/react/useReducer.md
c6e1987 
Co-authored-by: Maxim <mtitov92@gmail.com>
@kmpeeduwee @titovmx
Apply suggestions from code review
c92ae1c 
Co-authored-by: Maxim <mtitov92@gmail.com>
@kmpeeduwee
Copy link
Contributor Author

Привет! Хороший перевод! Заметил некоторое количество опечаток и проблем с пунктуацией - я бы рекомендовал прогнать всё через какой-нибудь редактор с проверкой орфографии. Также по соглашению мы используем букву ё в переводах - используйте пакет eyo, чтобы найти все места где должна быть использована ё

Привет! Большое спасибо за ревью – все поправил.

titovmx
titovmx reviewed Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@titovmx titovmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за исправления!
Перечитал и заметил еще пару пропущенных запятых.
Также, на мой взгляд, не стоит добавлять в репозиторий настройки для плагина vscode - переводчики могут пользоваться абсолютно разными редакторами и инструментами. Вы могли бы удалить папку .vscode из ветки?

src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
src/content/reference/react/useReducer.md Outdated Show resolved Hide resolved
kmpeeduwee and others added 4 commits November 4, 2023 21:43
@kmpeeduwee @titovmx
Update src/content/reference/react/useReducer.md
3eaff15 
Co-authored-by: Maxim <mtitov92@gmail.com>
@kmpeeduwee @titovmx
Update src/content/reference/react/useReducer.md
2303442 
Co-authored-by: Maxim <mtitov92@gmail.com>
@kmpeeduwee @titovmx
Update src/content/reference/react/useReducer.md
e191935 
Co-authored-by: Maxim <mtitov92@gmail.com>
@kmpeeduwee @titovmx
Update src/content/reference/react/useReducer.md
b04ea20 
Co-authored-by: Maxim <mtitov92@gmail.com>
@kmpeeduwee
Copy link
Contributor Author

Спасибо за исправления! Перечитал и заметил еще пару пропущенных запятых. Также, на мой взгляд, не стоит добавлять в репозиторий настройки для плагина vscode - переводчики могут пользоваться абсолютно разными редакторами и инструментами. Вы могли бы удалить папку .vscode из ветки?

Сделано! Спасибо :)

@kmpeeduwee kmpeeduwee requested a review from titovmx November 12, 2023 20:42
@titovmx titovmx merged commit 8e2e9c6 into reactjs:main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titovmx titovmx titovmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmpeeduwee @titovmx