Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of Error Boundaries into Russian #73

Merged
merged 24 commits into from
Feb 28, 2019

Conversation

mzhukov1973
Copy link
Contributor

No description provided.

@mzhukov1973 mzhukov1973 mentioned this pull request Feb 10, 2019
88 tasks
@gaearon
Copy link
Member

gaearon commented Feb 10, 2019

По терминологии, есть такое предложение #70

@mzhukov1973
Copy link
Contributor Author

Можно, особенно учитывая, что я никакого не использовал вообще - сейчас изменю.

@lex111 lex111 added the work in progress Author opened the pull-request but it's still being worked on label Feb 11, 2019
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Первый фидбек

content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzhukov1973 спасибо за исправления (и особенно за развернутые комментарии!). Добавил предложения, которые можно принять в этом пулреквесте.

Нужно решить как переводить следующее:

  • an error reporting service [] (сервис для отслеживания ошибок?)
  • to log (логирование?)
  • granularity (гранулярность что-то совсем непонятное, нужен простой синоним)

cc @another-guy

content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved

React 16 prints all errors that occurred during rendering to the console in development, even if the application accidentally swallows them. In addition to the error message and the JavaScript stack, it also provides component stack traces. Now you can see where exactly in the component tree the failure has happened:
В режиме разработки React 16 выводит на консоль сообщения обо всех ошибках, возникших при рендеринге, даже если приложения случайно их проглотило. Помимо сообщения об ошибке и стека JavaScript, React 16 также выводит и стек вызовов компонентов. Теперь вы в точности можете видеть в каком именно месте дерева компонентов случилось страшное:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

случайно их проглотило

Не очень понятно, что это означает. Типа ошибки, которые случаются при кодинге?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Имеются ввиду ошибки, которые по каким-то причинам не вызвали видимых проблем у приложения, ошибки, которые само приложение "приняло без жалоб" - "проглотило" )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Примерно поняно, но хочется поточнее как-то.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzhukov1973 @lex111

Рассмотрите варианты:

  • не проявило [видимым/заметным [пользователю] образом] -- перефразирование того, что уже сказано в комментарии выше;
  • проигнорировало;
  • подавило.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Остановился на варианте даже если они никак не сказались на работе приложения, но если что меняй на своё усмотрение.

content/docs/error-boundaries.md Outdated Show resolved Hide resolved
lex111 and others added 7 commits February 16, 2019 00:08
Co-Authored-By: mzhukov1973 <mzhukov31415dev@gmail.com>
Co-Authored-By: mzhukov1973 <mzhukov31415dev@gmail.com>
Co-Authored-By: mzhukov1973 <mzhukov31415dev@gmail.com>
Co-Authored-By: mzhukov1973 <mzhukov31415dev@gmail.com>
Co-Authored-By: mzhukov1973 <mzhukov31415dev@gmail.com>
Co-Authored-By: mzhukov1973 <mzhukov31415dev@gmail.com>
Co-Authored-By: mzhukov1973 <mzhukov31415dev@gmail.com>
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На момент прочтения, текст уже в очень хорошем состоянии! 👍 👍 👍

content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved

React 16 prints all errors that occurred during rendering to the console in development, even if the application accidentally swallows them. In addition to the error message and the JavaScript stack, it also provides component stack traces. Now you can see where exactly in the component tree the failure has happened:
В режиме разработки React 16 выводит на консоль сообщения обо всех ошибках, возникших при рендеринге, даже если приложения случайно их проглотило. Помимо сообщения об ошибке и стека JavaScript, React 16 также выводит и стек вызовов компонентов. Теперь вы в точности можете видеть в каком именно месте дерева компонентов случилось страшное:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzhukov1973 @lex111

Рассмотрите варианты:

  • не проявило [видимым/заметным [пользователю] образом] -- перефразирование того, что уже сказано в комментарии выше;
  • проигнорировало;
  • подавило.

content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved

## Naming Changes from React 15 {#naming-changes-from-react-15}
## Изменения в названиях по сравнению с React 15 {#naming-changes-from-react-15}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Режет слух заголовок. Я думал предложить Изменения наименований в сравнении с React 15, но тоже не нравится. 😒

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предложил свой вариант, если не нравится, то меняй на своё усмотрение.

@lex111
Copy link
Member

lex111 commented Feb 21, 2019

@mzhukov1973 вы можете рассмотреть предложенные правки?

@lex111
Copy link
Member

lex111 commented Feb 28, 2019

@another-guy принял твои изменения, поэтому посмотри ещё раз пулреквест, отредактируй, если считаешь нужным, и можно сливать.

@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for ru-reactjs ready!

Built with commit 329809e

https://deploy-preview-73--ru-reactjs.netlify.com

@another-guy another-guy merged commit aba41e0 into reactjs:master Feb 28, 2019
@another-guy another-guy removed their assignment Mar 2, 2019
@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed work in progress Author opened the pull-request but it's still being worked on labels Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants