Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Refs and the DOM #236

Merged
merged 57 commits into from
Mar 11, 2019
Merged

Translate Refs and the DOM #236

merged 57 commits into from
Mar 11, 2019

Conversation

SmolinPavel
Copy link
Contributor

@netlify
Copy link

netlify bot commented Mar 6, 2019 •
edited
Loading

Deploy preview for ru-reactjs ready!

Built with commit f197849

https://deploy-preview-236--ru-reactjs.netlify.com

@ntishkevich ntishkevich added the work in progress Author opened the pull-request but it's still being worked on label Mar 6, 2019
@tesseralis tesseralis mentioned this pull request Mar 6, 2019
Closed
88 tasks
another-guy
another-guy reviewed Mar 7, 2019
View reviewed changes
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Несколько замечаний по упрощению текста и следованию стилю, принятому в переводе других страниц.

Спасибо @SmolinPavel за перевод! 👍 👍 👍

content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
@another-guy another-guy added the needs review A pull request ready to be reviewed label Mar 7, 2019
@another-guy
Copy link
Collaborator

@SmolinPavel Ох, я не обратил внимание на то, что это draft. Но всё равно можете принять предложенные изменения прямо через GitHub. Это должно ускорить последующие ревью.

@SmolinPavel
Copy link
Contributor Author

@SmolinPavel Ох, я не обратил внимание на то, что это draft. Но всё равно можете принять предложенные изменения прямо через GitHub. Это должно ускорить последующие ревью.

@another-guy Завтра планирую добить остатки и отполировать! В любом случае, спасибо за замечания, я их все обязательно учту 👍

another-guy and others added 18 commits March 8, 2019 22:10
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
239c12c 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
2ac172e 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
192c904 
👍

Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
0488358 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
7a1388c 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
3eb7929 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
22e20f5 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
3b6f264 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
76ef587 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
722b7eb 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
f09899c 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@SmolinPavel
Fix titles case
6fc55a5
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
8225fec 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
de2d88b 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
546274a 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
f83161e 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
e77fa0b 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@another-guy @SmolinPavel
Update content/docs/refs-and-the-dom.md
bdadeb8 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@ntishkevich ntishkevich removed the needs review A pull request ready to be reviewed label Mar 9, 2019
ntishkevich and others added 13 commits March 10, 2019 23:29
@ntishkevich @SmolinPavel
Update content/docs/refs-and-the-dom.md
c29ef59 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@ntishkevich @SmolinPavel
Update content/docs/refs-and-the-dom.md
d3d04a7 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@ntishkevich @SmolinPavel
Update content/docs/refs-and-the-dom.md
c21a094 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@ntishkevich @SmolinPavel
Update content/docs/refs-and-the-dom.md
9154795 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@ntishkevich @SmolinPavel
Update content/docs/refs-and-the-dom.md
e5f5577 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@ntishkevich @SmolinPavel
Update content/docs/refs-and-the-dom.md
2a687dd 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@ntishkevich @SmolinPavel
Update content/docs/refs-and-the-dom.md
ef7f2bd 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@ntishkevich @SmolinPavel
Update content/docs/refs-and-the-dom.md
9861eab 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@SmolinPavel
Update nav.yml
5e11318
@ntishkevich @SmolinPavel
Update content/docs/refs-and-the-dom.md
bc1c393 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@ntishkevich @SmolinPavel
Update content/docs/refs-and-the-dom.md
2ed7f47 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@ntishkevich @SmolinPavel
Update content/docs/refs-and-the-dom.md
a5970c4 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@SmolinPavel
Fix PR comment
63806f9
@SmolinPavel
Copy link
Contributor Author

@SmolinPavel это странно, потому что @egorzekov тоже воспользовался этой новой возможностью гитхаба, и как я понял, у него кнопка видна, как собственно и мне (потому что я админ). Возможно, что-то блокирует эту кнопку? Расширение браузера? А если в другом браузере попробовать? Давайте попробуем разобраться. Всё-таки это может быть баг, тогда сможем помочь другим.

Попробовал в другом браузере - та же проблема :(

@SmolinPavel
Copy link
Contributor Author

@another-guy @lex111 @ntishkevich - Большое спасибо за ревью! 👍

lex111 and others added 3 commits March 10, 2019 23:43
@lex111 @SmolinPavel
Update content/docs/refs-and-the-dom.md
3123c69 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@lex111 @SmolinPavel
Update content/docs/refs-and-the-dom.md
f233a32 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@lex111 @SmolinPavel
Update content/docs/refs-and-the-dom.md
6c1acd4 
Co-Authored-By: SmolinPavel <isingwithaz@gmail.com>
@lex111
Copy link
Member

lex111 commented Mar 10, 2019

@SmolinPavel попробуйте написать в саппорт гитхаба, он обычно оперативно отвечает. Просто странно, в чём баг.

@SmolinPavel
Copy link
Contributor Author

@SmolinPavel попробуйте написать в саппорт гитхаба, он обычно оперативно отвечает. Просто странно, в чём баг.

@lex111 Проверил на другом проекте - у меня как у админа есть форма с классом branch-action-btn, которая отправляет пост запрос. На этой странице ничего нет. Да, сейчас напишу в саппорт

another-guy
another-guy approved these changes Mar 11, 2019
View reviewed changes
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SmolinPavel я так понял, что все правки внесены?

Approve ! 💯

@SmolinPavel
Copy link
Contributor Author

@another-guy Все правки внесены! В техподдержка GH уточнили, являюсь ли я автором PR, на что получили утвердительный ответ. Можно подождать, что они скажут, а можно вмержить и двигаться дальше 👍

@gcor
Copy link
Collaborator

gcor commented Mar 11, 2019

@SmolinPavel, можно сделать пул-реквест не черновым, нажав "ready for review".
Я сегодня ещё посмотрю текст.

@SmolinPavel
Copy link
Contributor Author

@SmolinPavel, можно сделать пул-реквест не черновым, нажав "ready for review".
Я сегодня ещё посмотрю текст.

@gcor Как раз с этим и проблема, т.к. у меня в мерж боксе нет такой кнопки (хотя я автор PR). Веду переписку с техподдержкой GH по данному вопросу

@another-guy another-guy marked this pull request as ready for review March 11, 2019 18:06
@another-guy
Copy link
Collaborator

@SmolinPavel учитывая, что ситуация затягивает ревью, я позволил себе отметить PR как ready for review и смёржить перевод. Спасибо оргомное за вклад!

@another-guy another-guy merged commit e2c66c2 into reactjs:master Mar 11, 2019
@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntishkevich ntishkevich ntishkevich left review comments

@lex111 lex111 lex111 left review comments

@another-guy another-guy another-guy approved these changes

Assignees
No one assigned
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SmolinPavel @another-guy @lex111 @gcor @ntishkevich