Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composition-vs-inheritance.md #225

Merged
merged 9 commits into from
Mar 10, 2019
Merged

Conversation

gcor
Copy link
Collaborator

@gcor gcor commented Mar 4, 2019

No description provided.

@gcor gcor force-pushed the composition-vs-inheritance branch from 5736680 to c0be4e5 Compare March 4, 2019 20:18
@netlify
Copy link

netlify bot commented Mar 4, 2019

Deploy preview for ru-reactjs ready!

Built with commit 5736680

https://deploy-preview-225--ru-reactjs.netlify.com

@gcor gcor added the needs review A pull request ready to be reviewed label Mar 4, 2019
@netlify
Copy link

netlify bot commented Mar 4, 2019

Deploy preview for ru-reactjs ready!

Built with commit 5b071d6

https://deploy-preview-225--ru-reactjs.netlify.com

@gcor gcor force-pushed the composition-vs-inheritance branch from 140284b to 9ca6dc6 Compare March 4, 2019 20:51
Co-Authored-By: gcor <anton@gcor.ru>
@lex111 lex111 mentioned this pull request Mar 4, 2019
88 tasks
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Небольшие советы по улучшению читаемости.

@gcor спасибо за оперативный перевод! 💯

content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
@another-guy another-guy requested a review from lex111 March 6, 2019 01:50
@another-guy
Copy link
Collaborator

@lex111 посмотри пожалуйста, как будет время. Тут не такой большой материал.

Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Жаль, что @aamorozov не присоединился к этому переводу, я его ждал, но ладно. Внёс небольшие поправки, теперь можем сливать.

@lex111 lex111 merged commit 1734526 into reactjs:master Mar 10, 2019
@lex111
Copy link
Member

lex111 commented Mar 10, 2019

Спасибо @gcor за оперативный перевод! А также @ntishkevich и @another-guy за ревью!

@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants