Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Hooks FAQ" - "Хуки - вопросы и ответы" - ready #208

Merged
merged 104 commits into from
Mar 11, 2019
Merged

"Hooks FAQ" - "Хуки - вопросы и ответы" - ready #208

merged 104 commits into from
Mar 11, 2019

Conversation

egorzekov
Copy link
Contributor

No description provided.

@gcor gcor added the work in progress Author opened the pull-request but it's still being worked on label Mar 1, 2019
@netlify
Copy link

netlify bot commented Mar 1, 2019 •
edited
Loading

Deploy preview for ru-reactjs ready!

Built with commit 04bfecd

https://deploy-preview-208--ru-reactjs.netlify.com

@tesseralis tesseralis mentioned this pull request Mar 1, 2019
Closed
88 tasks
@another-guy
Copy link
Collaborator

Хуки решено переводить со строчной буквы. Например, хук состояния, хук эффекта.

@egorzekov
Copy link
Contributor Author

Хуки решено переводить со строчной буквы. Например, хук состояния, хук эффекта.

Принял, спасибо

@another-guy another-guy self-assigned this Mar 2, 2019
@another-guy another-guy requested review from lex111 and gcor March 2, 2019 09:04
@another-guy
Copy link
Collaborator

@egorzekov лично я мало знаком с workflow, касающимися "draft review". Когда PR уже будет не в черновом варианте, оповестите, пожалуйста.

gcor
gcor reviewed Mar 2, 2019
View reviewed changes
Copy link
Collaborator

@gcor gcor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за перевод!

Вот немного улучшений для начала. В тексте есть еще моменты над которыми стоит поработать.

content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
content/docs/hooks-faq.md Outdated Show resolved Hide resolved
@egorzekov
Copy link
Contributor Author

@egorzekov лично я мало знаком с workflow, касающимися "draft review". Когда PR уже будет не в черновом варианте, оповестите, пожалуйста.

@another-guy , договорились

Вот немного улучшений для начала. В тексте есть еще моменты над которыми стоит поработать.

@gcor, спасибо за предожения. Однако, я еще сам не перечитывал переведённый контент на момент ошибок и построения предложений. ПР создан сейчас только для того, чтобы показать, что работа на статьёй (а она не маленькая) идёт.

Просьба не ревьювать контент, пока перевод не будет закончен, заранее благодарен!

gcor and others added 9 commits March 3, 2019 14:04
@gcor @egorzekov
Update content/docs/hooks-faq.md
f3470f5 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/hooks-faq.md
6353a9e 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/hooks-faq.md
ea2999f 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/hooks-faq.md
8ca661f 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/hooks-faq.md
a2ea822 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/hooks-faq.md
f78c58b 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/hooks-faq.md
9ec576c 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@egorzekov
Fix hooks first letter
9d9b0c7
@egorzekov
Almost done 26/32 sections translated
8f987d7
@egorzekov egorzekov changed the title Hooks FAQ translation (WIP) Hooks FAQ translation (WIP, progress - 26/32 sections, no review please for now) Mar 3, 2019
@another-guy
Copy link
Collaborator

@egorzekov спасибо за работу! 🚀 Буду ждать "отмашки".

@egorzekov egorzekov changed the title Hooks FAQ translation (WIP, progress - 26/32 sections, no review please for now) Hooks FAQ translation (WIP, progress - 32/32 sections, formatting/verifications left, no review please for now) Mar 6, 2019
@egorzekov
Copy link
Contributor Author

JFYI

Переведены все секции.

Осталось перечичать\отформатировать\исправить ошибки\завершить несколько TODO.
ETA ~2 дня

Когда закончу, дам финальную отмашку всем участникам этого ПР.

@egorzekov egorzekov marked this pull request as ready for review March 8, 2019 08:01
another-guy and others added 26 commits March 11, 2019 14:19
@another-guy @egorzekov
Update content/docs/hooks-faq.md
7bd3cae 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
07c8e4b 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
2e02f04 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
9183182 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
3ddd8d2 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
c419e60 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
a32bfe9 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
d3eb370 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
cf9dfeb 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
7177b45 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
ead9032 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
1eef4ab 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
d20d301 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
fdb575a 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
f08bf37 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
e3796cc 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
015e68a 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
ccd583d 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
e007633 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
b1f70a4 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
1ff2db6 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
aaeaa39 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
7523319 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
67bab43 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Update content/docs/hooks-faq.md
90536a7 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy @egorzekov
Apply suggestions from code review
04bfecd 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Mar 11, 2019
@another-guy another-guy merged commit 0f1abd6 into reactjs:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntishkevich ntishkevich ntishkevich left review comments

@gcor gcor gcor left review comments

@another-guy another-guy another-guy approved these changes

@lex111 lex111 lex111 approved these changes

Assignees
No one assigned
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@egorzekov @another-guy @lex111 @gcor @ntishkevich