Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: googleTranslate breaking terminal blocks #3993

Conversation

shrirambalaji
Copy link
Contributor

@shrirambalaji shrirambalaji commented Oct 24, 2021

Follow up to #3984. cc @rachelnabors

image

@shrirambalaji
Copy link
Contributor Author

shrirambalaji commented Oct 24, 2021

@rachelnabors quick question: Readme.md mentions a yarn check-all script, which is missing. I'm assuming there are CI warnings too as local prettier, eslint aren't run locally.

Should the docs maybe updated to the right steps instead? (I'll make a PR for it)

@rachelnabors
Copy link
Contributor

rachelnabors commented Oct 24, 2021

Awesome! Thanks for the fast follow up!

sm_thanks

As for the Readme.md, that doesn't apply to the beta docs site IIRC. We might need to rethink it. Thanks for the reminder!

@rachelnabors rachelnabors merged commit 7fcceca into reactjs:beta Oct 24, 2021
gaearon pushed a commit that referenced this pull request Oct 28, 2021
* fix: googleTranslate breaking terminal blocks

* chore: prettier magic
gaearon pushed a commit that referenced this pull request Oct 28, 2021
* fix: googleTranslate breaking terminal blocks

* chore: prettier magic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants