Style scrollbars in dark mode #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks way better. Thanks! |
|
I reverted this because it made the layout jump when toggling dark/light theme, and also made some of the sidebar content wrap in dark mode. We still need to fix this but the fix would need to be a bit more careful. |
gaearon
pushed a commit
that referenced
this pull request
Oct 28, 2021
gaearon
pushed a commit
that referenced
this pull request
Oct 28, 2021
|
Can you please resubmit if you'd like, but fix the issue? The beta is now in the |
|
Sure, I'll give it a go. I've not seen this issue occure. Do you know what pages seem affected? Or does it happen on a specific screen side? |
|
I was seeing it when switching between dark and light mode (on any page): the switch would jump because of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome (and probably other webkit based browsers) doesn't automatically darken scrollbars.
Before:
After: